Member ADnote::ComputeVoiceOscillator_CubicInterpolation (int nvoice)

remove this declaration if it is commented out

Member Alienwah::out (const Stereo< float * > &smp)

Rework, as optimization can be used when the new complex type is utilized. Before all calculations needed to be done with individual float, but now they can be done together

Member AlsaEngine::interleave (const Stereo< float * > &smps)

TODO fix repeated allocation

Struct calf_plugins::ladspa_plugin_info

XXXKF lacks the "new" id-label-name triple

Struct calf_plugins::organ_enums

Member calf_plugins::PF_UNITMASK

reduce to use only 5 bits

Member Controller::used

see if this can be a bool

Struct dsp::basic_synth

it would make sense to support all notes off controller too

Class Dump

see if this object should have knowledge about the file that it will write to

upgrade from stdio to iostream

Member Dump::dumpcontroller (char chan, unsigned int type, int par)

figure out what type is exactly meaning

Member Dump::startnow ()

see if this fits better in the constructor

Class EffectLFO

see if this should inherit LFO

Member LFO::lfotype

see if an enum would be better here

Member lmms::gui::AutomationEditor::paintEvent (QPaintEvent *pe) override

move this horizontal line drawing code into the same loop as the value ticks?

Member lmms::gui::ClipView::fixedClips ()

In what circumstance are they fixed?

Member lmms::gui::ClipView::mouseMoveEvent (QMouseEvent *me) override

what does the final else case do here?

Member lmms::gui::PianoRoll::showVolTextFloat (volume_t vol, const QPoint &pos, int timeout=-1)

display velocity for MIDI-based instruments

Member lmms::gui::PianoView::contextMenuEvent (QContextMenuEvent *_me) override

Is this right, or does this create the context menu?

Member lmms::gui::PianoView::focusOutEvent (QFocusEvent *_fe) override

Is there supposed to be a parameter given here?

Member lmms::gui::PianoView::getKeyX (int _key_num) const

is this description of what the method does correct?

replace the final subtract with initialising x to width/2.

Member lmms::gui::PianoView::mouseMoveEvent (QMouseEvent *me) override

Paul Wayper thinks that this code should be refactored to reduce or remove the duplication between this, the mousePressEvent() and mouseReleaseEvent() methods.

Member lmms::gui::PianoView::paintEvent (QPaintEvent *) override

Is there supposed to be a parameter given here?

Member lmms::gui::PianoView::PianoView (QWidget *_parent)

are the descriptions of the m_startkey and m_lastkey properties correct?

Member lmms::gui::TrackView::createClipView (lmms::Clip *clip)

is this a good description for what this method does?

Member lmms::gui::TrackView::TrackView (Track *_track, TrackContainerView *tcv)

Is my description of these properties correct?

Member lmms::Plugin::Descriptor::SubPluginFeatures::Key::name

This is a bug, there should be a function in SubPluginFeatures (to get the name) instead

Member lmms::Track::getClip (std::size_t clipNum) -> Clip *

reject Clip numbers less than zero.

if we create a Clip here, should we somehow attach it to the track?

Member lmms::Track::insertBar (const TimePos &pos)

if we stepped through this list last to first, and the list was in ascending order by Clip time, once we hit a Clip that was earlier than the insert time, we could fall out of the loop early.

Member lmms::Track::loadTrack (const QDomElement &element, bool presetMode)

Load the track height.

Member lmms::Track::saveTrack (QDomDocument &doc, QDomElement &element, bool presetMode)

Does this accurately describe the parameters? I think not!?

Save the track height

Member lmms::Track::Track (Type type, TrackContainer *tc)

check the definitions of all the properties - are they OK?

Member main (int argc, char *argv[])

check this process for a small memory leak

Member Master::part [NUM_MIDI_PARTS]

see if this can be made to be dynamic

Member Master::vuoutpeakpart [NUM_MIDI_PARTS]

synchronize this with a mutex

Member Microtonal::texttomapping (const char *text)

better description

Member Microtonal::texttotunings (const char *text)

better description

Struct oss_count_t

Get rid of OSS_NO_LONG_LONG references?

Member set_realtime ()

see if the right pid is being sent

see if this is having desired effect, if not then look at pthread_attr_t

Member SOUND_VERSION

reorganize layout more like the 4Front version

ask about maintaining __SIOWR vs. _IOWR ioctl cmd defines

Member XmlData::addparams (const char *name, unsigned int params,...)

make this function send out a good error message if something goes wrong

Member zyncarla::ADnote::ComputeVoiceOscillator_CubicInterpolation (int nvoice)

remove this declaration if it is commented out

Member zyncarla::Alienwah::out (const Stereo< float * > &smp)

Rework, as optimization can be used when the new complex type is utilized. Before all calculations needed to be done with individual float, but now they can be done together

Member zyncarla::AlsaEngine::interleave (const Stereo< float * > &smps)

TODO fix repeated allocation

Member zyncarla::Controller::used

see if this can be a bool

Class zyncarla::EffectLFO

see if this should inherit LFO

Member zyncarla::Master::part [NUM_MIDI_PARTS]

see if this can be made to be dynamic

Member zyncarla::Microtonal::texttomapping (const char *text)

better description

Member zyncarla::Microtonal::texttotunings (const char *text)

better description

Member zyncarla::set_realtime ()

see if the right pid is being sent

see if this is having desired effect, if not then look at pthread_attr_t

Member zyncarla::XMLwrapper::addparams (const char *name, unsigned int params,...) const

make this function send out a good error message if something goes wrong

Member zyncarla::XMLwrapper::addparbool (const std::string &name, int val)

Fix this reverse boolean logic.